Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7961

Add environment variable DISABLE_ESLINT

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/travelperk/master into master Nov 11, 2019
  • Overview 16
  • Commits 4
  • Pipelines 0
  • Changes 2

Created by: giuband

The idea behind this new environment DISABLE_ESLINT_DEV variable is to:

  1. speed up compilation time on dev mode
  2. allow developers to write temporary code without caring about ESLint too much.

At the moment 2) is pretty hard, because depending on your ESLint config you might not even able to have a console.log or an unused variable in your code without seeing your dev build failing, making the experience pretty frustrating.

Open for feedback. I am actually uncertain whether we should have instead just a DISABLE_ESLINT setting that would disable ESLint for both environments.

Related issues:

  • https://github.com/facebook/create-react-app/issues/7828
  • https://github.com/facebook/create-react-app/issues/7078
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/travelperk/master