Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !7988

Bump webpack-dev-server

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ianschmitz/bump-wds into master Nov 16, 2019
  • Overview 2
  • Commits 4
  • Pipelines 0
  • Changes 8

Created by: ianschmitz

Closes #7782 (closed).

Updates webpack-dev-server from 3.2.1 to 3.9.0.

I was able to resolve the previous issues i experienced when trying the upgrade before in #7473. The error appears to be related to our usage of sockjs-client inside of the webpackHotDevClient and jsdom. Switching to using native a WebSocket instead made everything happy.

yarn start works nicely. Code changes cause page refresh, style changes causes a hot replacement of styles as expected, and error overlay works.

I tagged as a breaking change for react-dev-utils only as this change could potentially affect someone out there due to the change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ianschmitz/bump-wds