Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8003

Use @typescript-eslint/no-unused-expressions to support optional chaining

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/maxdavidson/fix-optional-chaining-linting into master Nov 19, 2019
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: maxdavidson

Eslint's no-unused-expressions rule doesn't support the new optional chaining syntax and yields false positives. Typescript-eslints's equivalent was recently updated to support it, so use it instead.

This fix only affects TypeScript, so in order to make it work for plain JavaScript we'd have to wait for official Eslint support or perhaps add another plugin like this one.

image

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/maxdavidson/fix-optional-chaining-linting