Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8063

Disable ESLint's buggy no-unused-expressions rule

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/mjackson/disable-no-unused-expressions into master Dec 02, 2019
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: mjackson

ESLint's no-unused-expressions rule is buggy. It currently considers the r() in r(), e.retry() to be an "unused expression" which they define as an expression "which has no effect on the state of the program". So I'm suggesting we disable it entirely in CRA.

Side note: I noticed it's already disabled for TypeScript users so this change maintains parity with linting TS. Or hey, maybe I should just go write all my code in TypeScript :P

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mjackson/disable-no-unused-expressions