Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8175
An error occurred while fetching the assigned milestone of the selected merge_request.

Optimize localhost detection regex in service worker templates

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/dominique-mueller/refactor/service-worker-localhost-regex into master 5 years ago
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: dominique-mueller

As detected by eslint-plugin-optimize-regex, the regular expression that is used in the service worker template(s) to determine whether the hostname is localhost can be optimized. This PR includes the refactoring.

ESLint warning:

ESLint warning

Loading
Loading

Activity


  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator added CLA Signed label 5 years ago

    added CLA Signed label

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: heyimalex

    Review: Approved

    Approval is for correctness, pretty ambivalent to the change itself :shrug:‍♂

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: stale[bot]

    This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

  • Administrator added stale label 5 years ago

    added stale label

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: stale[bot]

    This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

  • Administrator closed 5 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference:
Source branch: github/fork/dominique-mueller/refactor/service-worker-localhost-regex

Menu

Explore Projects Groups Snippets