Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8215

cleanup @babel/plugin-transform-destructuring configuration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/henryqdineen/fix-destructuring-plugin-config into master Dec 20, 2019
  • Overview 7
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: henryqdineen

The @babel/plugin-transform-destructuring Babel plugin does not have a selectiveLoose option currently and this code has been a source of confusion for me and possibly others. It was introduced in https://github.com/facebook/create-react-app/pull/5997 and I'm not sure if the intention was to wait for the selectiveLoose option to be available. Even if this worked as hoped for I think that only useState and useReducer should be targeted for this optimization.

Thanks! Please let me know if I'm missing something obvious.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/henryqdineen/fix-destructuring-plugin-config