Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8253

Fix EXTEND_ESLINT bug

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/0xkoffee/patch-2 into master Dec 29, 2019
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: 0xkoffee

Fixed webpack.config.js so that it can match eslint config for typescript (*.ts) files as well.

eslint.CLIEngine was extracting eslint configs for only js files because paths.appIndexJs was passed to getConfigForFile

eslint.CLIEngine uses the relative path of given path to extract matching configs, so it was only extracting configs for *.js.

Fixed it by passing *.ts instead.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/0xkoffee/patch-2