Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8281

Fix sass importLoaders

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/mariusc23/fix/sass-import-loaders into master Jan 03, 2020
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: mariusc23

This PR fixes the importLoaders setting for sass files. I believe this was broken in #5829 when an additional loader was introduced but the importLoaders setting was not incremented.

I ran into this trying to upgrade react-scripts locally. Verified this change fixes it for our project.

This is the error I ran into:

Error: resolve-url-loader: CSS error
  file:///MySassFile.module.scss:42:6: Unknown word
You tried to parse SCSS with the standard CSS parser; try again with the postcss-scss parser
  You tried to parse SCSS with the standard CSS parser; try again with the postcss-scss parser
    at runMicrotasks (<anonymous>)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mariusc23/fix/sass-import-loaders