Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8307

Remove outdated docs regarding vscode eslint extension and typescript autofix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/john-james-gh/master into master Jan 10, 2020
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: john-james-gh

I would like to remove documentation that is no longer relevant (outdated). It is regarding ESLint extension for Visual Studio Code and its Typescript support. https://github.com/Microsoft/vscode-eslint/issues/609

Before ESLint extension version 2.0.4 (before December 16, 2019 source: https://github.com/microsoft/vscode-eslint/releases), the extension did not have Typescript support (auto-fix feature) enabled by default and it had to be enabled manually by adding a specific configuration in .vscode/settings.json (the block removed by this PR)

As aforesaid, this issue with ESLint not having TypeScript support enabled by default has been fixed with version 2.0.4 (released on Dec 16, 2019) and this block of code (workaround) is no longer relevant. Capture source: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint

In fact this configuration is now squiggle-lined once added to .vscode/settings.json with a warning as shown in the screenshot.

Screenshot (31)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/john-james-gh/master