Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8376

Make @typescript-eslint optional peerDependencies

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ThewBear/ThewBear-remove-typescript-eslint-peerdeps into master Jan 26, 2020
  • Overview 6
  • Commits 19
  • Pipelines 0
  • Changes 6

Created by: ThewBear

Problem

Currently eslint-config-react-app requires @typescript-eslint to be installed in every project even the project that doesn't use typescript. This lead to the warning of missing typescript (#6834 , #6859).

Solution

By making @typescript-eslint an optional peerDependencies, non-typescript user doesn't need to installed @typescript-eslint and can get rid of the warning. User who use typescript can installed typescript along with @typescript-eslint/eslint-plugin and @typescript-eslint/parser.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ThewBear/ThewBear-remove-typescript-eslint-peerdeps