Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8406

Upgrade testing-library packages

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/gnapse/upgrade-jest-dom-version into master Jan 31, 2020
  • Overview 1
  • Commits 5
  • Pipelines 0
  • Changes 7

Created by: gnapse

jest-dom's latest major version has its type definitions moved to DefinitelyTyped (see testing-library/jest-dom#123). This make it so the TypeScript definitions work automatically without config. This PR upgrades the version referenced in the template so that newly generated projects get the newest version right from the start.

The newest jest-dom version also makes it so that the main module takes care of extending expect, so this PR includes the following change where appropriate (though the usual way still works):

-import '@testing-library/jest-dom/extend-expect';
+import '@testing-library/jest-dom';

This PR also takes the liberty to upgrade the actual dev dependency of create-react-app itself. Ran the tests and it all worked. Hope that's ok too.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gnapse/upgrade-jest-dom-version