Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8412

Change arrow functions to function declarations

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/lewislbr/functions-are-defined-inconsistently into master 5 years ago
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: lewislbr

The JavaScript template uses a function declaration to define the App component, the TypeScript template and a page of the documentation used arrow functions. Changed it to use function declarations for consistency and readability.

Approval is optional

Merged by (Jul 25, 2025 4:49am UTC)

Merge details

  • Changes merged into master with 14cd24ea.
  • Deleted the source branch.

Activity


  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator added CLA Signed label 5 years ago

    added CLA Signed label

  • Administrator changed milestone to %3.4 5 years ago

    changed milestone to %3.4

  • Administrator added tag: enhancement label 5 years ago

    added tag: enhancement label

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Merged by: andriijas at 2020-02-03 14:28:40 UTC

  • Administrator closed 5 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
CLA Signed tag: enhancement
2
CLA Signed tag: enhancement
    Assign labels
  • Manage project labels

Milestone
3.4
3.4
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!8412
Source branch: github/fork/lewislbr/functions-are-defined-inconsistently

Menu

Explore Projects Groups Snippets