Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8671

Allow subdomains in dev server

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/cyberixae/allow_subdomains into master Mar 18, 2020
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: cyberixae

This is my attempt to get rid of the DANGEROUSLY_DISABLE_HOST_CHECK while working on apps that need the API proxy and subdomains. I'm wondering whether or not subdomains are vulnerable to similar spoofing attacks. At least one would expect the attack vector to be smaller if allowed hosts would be restricted to subdomains. See #2233 (closed) for previous discussion.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/cyberixae/allow_subdomains