Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !8939

Bump React Hooks ESLint plugin to 4.0.0

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge lint into master 5 years ago
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: gaearon

Changelog: https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md

Note some of these will likely cause false positives:

  • https://github.com/facebook/react/pull/18722
  • https://github.com/facebook/react/pull/18341
  • https://github.com/facebook/react/pull/16455

People who get them will likely complain because it's really annoying. But we think the change itself is worth it and it's a bitter pill we need to swallow now rather than prolong it. The workaround, as always, is to disable-line the ones that are false positives and, ideally, rename them in code.

Approval is optional

Merged by (Jul 26, 2025 1:16am UTC)

Merge details

  • Changes merged into master with 30643d21.
  • Deleted the source branch.

Activity


  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator requested review from @root 5 years ago

    requested review from @root

  • Administrator added CLA Signed label 5 years ago

    added CLA Signed label

  • Administrator added tag: breaking change label and removed CLA Signed label 5 years ago

    added tag: breaking change label and removed CLA Signed label

  • Administrator changed milestone to %4.0 5 years ago

    changed milestone to %4.0

  • Administrator added tag: underlying tools label 5 years ago

    added tag: underlying tools label

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Merged by: ianschmitz at 2020-05-04 01:27:15 UTC

  • Administrator closed 5 years ago

    closed

  • Administrator
    Administrator @root · 5 years ago
    Author Contributor

    Created by: ianschmitz

    Thanks Dan!

    @iansu, this would be good to reference in the release notes when we get to it to set expectations of the false positives.

  • Administrator mentioned in issue #8505 (closed) 5 years ago

    mentioned in issue #8505 (closed)

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
tag: breaking change tag: underlying tools
2
tag: breaking change tag: underlying tools
    Assign labels
  • Manage project labels

Milestone
4.0
4.0
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!8939
Source branch: lint

Menu

Explore Projects Groups Snippets