Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !9021

Pin babel-preset-react-app to to core-js minor '3.5' version and add a peer dependency

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/Mrman/core-js-config-change into main 5 years ago
  • Overview 15
  • Commits 4
  • Pipelines 0
  • Changes 3

Created by: Mrman

  • Specified the minor version as recommended by core-js docs
  • Removed comment about core-js@3 upgrade
  • Added peer dependency on core-js from babel-preset-react-app.

Did some due dilligence and see react-error-overlay and react-scripts both directly depend on babel-preset-react-app but do not have a direct dependency on core-js. They do both have direct dependencies on react-app-polyfill that in turn depends on core-js.

From my testing:

  • npm doesn't complain about the peer depenency being unmet, guessing because it sees core-js in the dependency tree from react-app-polyfill
  • yarn does warn about the peer dependency being unmet, this seems more correct than npm's behaviour.

Forgive my ignorance but I don't know if babel-preset-react-app is expected to be usable without core-js? If not does that suggest react-scripts and react-error-overlay should have a direct dependency on core-js too?

closes #8875 (closed) closes #8779

Activity

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
  1. 02 Jan, 2021 1 commit
    • Craig S's avatar
      Merge branch 'master' into core-js-config-change · bcb0a63d
      Craig S authored 4 years ago
      Unverified
      bcb0a63d
  2. 22 May, 2020 2 commits
    • Craig S's avatar
      Update to '3.5' instead of number · 291e1072
      Craig S authored 5 years ago
      
      Co-authored-by: default avatarMinh Nguyen <minhnguyenxx@gmail.com>
      Unverified
      291e1072
    • Craig S's avatar
      Update to '3.5' instead of number · c7dbf276
      Craig S authored 5 years ago
      
      Co-authored-by: default avatarMinh Nguyen <minhnguyenxx@gmail.com>
      Unverified
      c7dbf276
  3. 15 May, 2020 1 commit
    • Mrman's avatar
      Pin to core-js 3.5.0 and add a peer dependency · caf745b8
      Mrman authored 5 years ago
      caf745b8
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
CLA Signed
1
CLA Signed
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!9021
Source branch: github/fork/Mrman/core-js-config-change

Menu

Explore Projects Groups Snippets