Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !9171

fix: improve DefinePlugin config

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/sdemjanenko/fix_getClientEnvironment_stringify into master Jun 16, 2020
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: sdemjanenko

This configuration is used in webpack's DefinePlugin which prefers keys that look like process.env.REACT_APP_MY_ENV_VAR instead of a nested object: https://webpack.js.org/plugins/define-plugin/

Prior to this change, webpack would replace all occurrences of process.env with a JS object containing every key in the environment that begins with REACT_APP.

The expected behavior is that a reference to process.env.REACT_APP_MY_ENV_VAR is replaced with the value of just that environment variable.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/sdemjanenko/fix_getClientEnvironment_stringify