Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !9205

Switch to the Workbox InjectManifest plugin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jeffposnick/wb-inject-manifest into master Jun 23, 2020
  • Overview 23
  • Commits 26
  • Pipelines 0
  • Changes 8

Created by: jeffposnick

Fixes https://github.com/facebook/create-react-app/issues/9141

More details about this change can be found in https://github.com/facebook/create-react-app/issues/9141#issue-637179372

This PR includes a filename change from src/serviceWorker.js to src/registerServiceWorker.js, but I didn't include any of the "automation" steps @mrmckeb mentioned in https://github.com/facebook/create-react-app/issues/9141#issuecomment-647934755. I'm not sure how to implement that.

It's been a while since I've contributed to c-r-a, so apologies if I'm missing anything! I'll add in a few inline comments with particular bits I'm not sure of.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jeffposnick/wb-inject-manifest