Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !9310

Explicitly exclude node_modules/ in ESLint configuration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/textbook/dont-lint-deps into main Jul 15, 2020
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: textbook

Although ESLint excludes node_modules/ by default when actually linting, the overrides rule for TypeScript does scan the dependencies when looking for TypeScript files (using files: '**/*.ts?(x)'). That means that, even if the linted code contains no TypeScript at all, the override triggers. An attempt to load @typescript-eslint/parser is made, which fails due to TypeScript not being installed.

This PR adds an explicit top-level ignore for node_modules/, which appears to prevent this (tested with a vanilla app made using npx create-react-app@latest).

Fixes #8745 (closed), #8936.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/textbook/dont-lint-deps