Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !937

Add support for `PUBLIC_URL` env variable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/EnoahNetzach/master into master Oct 20, 2016
  • Overview 30
  • Commits 5
  • Pipelines 0
  • Changes 13

Created by: EnoahNetzach

Solves https://github.com/facebookincubator/create-react-app/issues/936, introducing the possibility to specify the PUBLIC_URL env variable while running npm run build.

With this PR the %PUBLIC_URL% in static assets and the output.publicPath variable set in webpack configs follow the following behavior:

  • "homepage" specified in package.json, PUBLIC_URL not set: only the pathname is used from "homepage" (as it is right now);
  • PUBLIC_URL set, "homepage" might be set: the full url specified in the env variable is used
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/EnoahNetzach/master