Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !9558

Remove isExtendingEslintConfig variable on eject

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/lukyth/lukyth/remove-eslint-config-eject into master Aug 28, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: lukyth

The part of webpack config that use isExtendingEslintConfig will be removed on eject, the variable itself hasn't been removed yet. This PR makes the variable to be removed on eject as well.

The code block that use this variable:

// @remove-on-eject-begin
ignore: isExtendingEslintConfig,
baseConfig: isExtendingEslintConfig
  ? undefined
  : {
      extends: [require.resolve('eslint-config-react-app')],
    },
useEslintrc: isExtendingEslintConfig,
// @remove-on-eject-end
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/lukyth/lukyth/remove-eslint-config-eject