Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !959

Always build before deploying to gh-pages

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/dsernst/patch-1 into master Oct 25, 2016
  • Overview 6
  • Commits 5
  • Pipelines 0
  • Changes 1

Created by: dsernst

Pretty simple docs change:

Recommendations for package.json scripts for deploying to Github Pages:

+"deploy": "npm run build && gh-pages -d build"
-"deploy": "gh-pages -d build"

It seems very unlikely the user would want to deploy without rebuilding and can be confusing since the dev server automatically rebuilds.

This also adds a line to these deploy docs instructing where to put the CNAME file:

+You can configure a custom domain with GitHub pages, by adding a `CNAME` file to the `public/` folder.

This fixes https://github.com/facebookincubator/create-react-app/issues/654

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dsernst/patch-1