Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !9788

fix: resolve new JSX transform issues

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge fix/move-react-transform-check into master Oct 12, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: mrmckeb

This PR resolves two issues with CRAv4 and React's new JSX transform - originally implemented in #9645.

  • The configuration has been moved to the Babel config, which means it will now work with Jest.
  • Conflicting ESLint rules are now automatically disabled.

I made the decision not to share the small helper as I didn't want to add another dependency to babel-preset-react-app and eslint-config-react-app, but that's of course open to discussion/ideas.

Resolves #9772 (closed), resolves #9782 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/move-react-transform-check