Fix e2e docker tests fails on lerna publish and other test fixes

Created by: raix

This pull-request attempts to fix the e2e:docker test suite locally

• Remove local packages from the local package registry (verdaccio) before publishing new packages with the same version should fix #6660
• Make puppeteer run in the local docker image by using a custom development image (also configured for "development in docker" supported by vs code/github etc.) for better debugging options - puppeteer complained about missing X11lib
• Prevent yarn e2e:docker to start running if git has untracked changes - this would cause the tests to fail at some point

Not in this pull-request is fixing test issues:

• Have the local registry started in the development image and expose the port providing better means to debug
• ModuleScopePlugin is triggered on local package like webpackHotDevClient in smoke tests, will be fixed in #9805
• e2e-installs.sh last test Test when PnP is enabled is broken (at least locally)

Created by: facebook-github-bot

Hi @raix!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Created by: raix

I just saw new errors on master that I don't have locally yet... I'll close this pull-request until master passes tests, to make sure I don't contribute to more issues in the test setup.

closed

reopened

Created by: raix

@iansu This pull-request should fix e2e:docker and puppeteer locally (I guess also add support for github/vs code "development in docker") Not sure if it's the right time to make this change, I initially closed the pr because tests keep failing on CI for different reasons - seems like we are currently in a bad state?

Would be nice to have all tests passing and block merges to master if they are not. (eg. when making this change and updating the project to webpack 5 I could only see my app working, but not if I was breaking any tests)

added CLA Signed label

Created by: facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

added tag: internal label

mentioned in issue #9994 (closed)

mentioned in merge request !10217 (merged)

mentioned in merge request !11329

changed milestone to %5.x

closed