Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !9846

check if descriptionFileRoot is not undefined

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/greguintow/master into master Oct 21, 2020
  • Overview 8
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: greguintow

Problem

I'm currently building a project using nx monorepo tool, they have its own react config, but the bundle is bigger and doesn't have the cool way to show eslint errors like here. But it has some conflicts when have a package.json inside the project.

Solution

I ejected a create-react-app project and made the required changes to don't use the package.json, but in this file that I changed the descriptionFileRoot was getting undefined. So I just checked if was not undefined and then started working on the project without a package.json file.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/greguintow/master