Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !9988

Upgrade sass-loader

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ehsankhfr/ISSUE-9986-sass-loader-upgrade into master Nov 02, 2020
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: ehsankhfr

Fix #9986 (closed) With the current node-sass version (v5), react-script won't survive.

TEST PLAN

With the sass-loader version upgrade and new version of node-sass:

  1. npx create-react-app sass-error-compilation
  2. cd sass-error-compilation
  3. yarn add node-sass@5.0.0
  4. Modify App.css to App.scss. Change extension in App.js as well.
  5. change the sass-loader version in node_modules/react-scripts/package.json to ^10.0.5
  6. yarn add sass-loader@10.0.5
  7. yarn start
  8. Should work successfully

With the sass-loader version upgrade and old version of node-sass:

  1. npx create-react-app sass-error-compilation
  2. cd sass-error-compilation
  3. yarn add node-sass@4.14.1
  4. Modify App.css to App.scss. Change extension in App.js as well.
  5. change the sass-loader version in node_modules/react-scripts/package.json to ^10.0.5
  6. yarn add sass-loader@10.0.5
  7. yarn start
  8. Should work successfully

Without the version upgrade and and new version of node-sass:

  1. npx create-react-app sass-error-compilation
  2. cd sass-error-compilation
  3. yarn add node-sass@5.0.0
  4. Modify App.css to App.scss. Change extension in App.js as well.
  5. yarn start
  6. Should fail to run with version incompatibility error
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ehsankhfr/ISSUE-9986-sass-loader-upgrade