From 9399b6527831d0e2308d29c320fd76d391e04182 Mon Sep 17 00:00:00 2001 From: ubatin <mglwinkyawmyat@gmail.com> Date: Mon, 23 Oct 2017 20:59:37 +0630 Subject: [PATCH 1/2] Add necessary packages for .eslintrc --- app/package.json | 12 ++++++++++-- app/src/App.jsx | 26 +++++++++++++------------- 2 files changed, 23 insertions(+), 15 deletions(-) diff --git a/app/package.json b/app/package.json index fb28a05550..31d99f055c 100644 --- a/app/package.json +++ b/app/package.json @@ -4,11 +4,19 @@ "private": true, "homepage": "https://roshanjossey.github.io/first-contributions", "devDependencies": { + "babel-eslint": "^8.0.1", "enzyme": "^3.0.0", + "eslint": "^4.9.0", + "eslint-config-airbnb": "^16.1.0", + "eslint-plugin-babel": "^4.1.2", + "eslint-plugin-import": "^2.8.0", + "eslint-plugin-jsx": "0.0.2", + "eslint-plugin-jsx-a11y": "^6.0.2", + "eslint-plugin-react": "^7.4.0", "gh-pages": "^0.12.0", "react-scripts": "0.7.0", - "sw-precache": "^5.2.0", - "react-test-renderer": "^15.0.0" + "react-test-renderer": "^15.0.0", + "sw-precache": "^5.2.0" }, "dependencies": { "react": "^15.4.0", diff --git a/app/src/App.jsx b/app/src/App.jsx index 6bf295e539..af1037598e 100644 --- a/app/src/App.jsx +++ b/app/src/App.jsx @@ -6,19 +6,19 @@ import CardsContainer from './components/ProjectList/CardsContainer'; import SocialShare from './components/SocialShare/SocialShare'; class App extends Component { - render() { - return ( - <div className="App"> - <Navbar /> - <div className="App-header"> - <h1>Make your first open source contribution in 5 minutes</h1> - </div> - <LinkButton /> - <CardsContainer /> - <SocialShare/> - </div> - ); - } + render() { + return ( + <div className="App"> + <Navbar /> + <div className="App-header"> + <h1>Make your first open source contribution in 5 minutes</h1> + </div> + <LinkButton /> + <CardsContainer /> + <SocialShare /> + </div> + ); + } } export default App; -- GitLab From dcddf30943af1e3a3875e2b1c9e4d067b55a9a81 Mon Sep 17 00:00:00 2001 From: ubatin <mglwinkyawmyat@gmail.com> Date: Mon, 23 Oct 2017 21:00:20 +0630 Subject: [PATCH 2/2] Add .eslintrc file for modern editor --- app/.eslintrc | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 app/.eslintrc diff --git a/app/.eslintrc b/app/.eslintrc new file mode 100644 index 0000000000..58aa14893f --- /dev/null +++ b/app/.eslintrc @@ -0,0 +1,33 @@ +{ + "parser": "babel-eslint", + "plugins": [ + "react", + "babel", + "jsx", + ], + "extends": [ + "plugin:react/recommended", + "airbnb" + ], + "parserOptions": { + "ecmaVersion": 6, + "sourceType": "module", + "ecmaFeatures": { + "jsx": true, + } + }, + "env": { + "browser": true, + "node": true + }, + "rules": { + "quotes": [2, "single"], + "strict": [2, "never"], + "comma-dangle": [2, "never"], + "no-underscore-dangle": 0, + "react/jsx-uses-react": 2, + "react/jsx-uses-vars": 2, + "react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }], + "react/react-in-jsx-scope": 2, + } +} -- GitLab