Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • N node-http-proxy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 482
    • Issues 482
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • http ... PARTY!
  • node-http-proxy
  • Merge requests
  • !1182

issue #953: stop using writeHead

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/jakefurler/953-stop-using-write-head into master 8 years ago
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: jakefurler

Using object.keys in web-incoming.js results in a non-deterministic ordering of keys, which means that in web-outgoing writeHead might be called before setHeader, which throws an error.

Example of a server that fails to send a response :

const http = require('http');

const server = http.createServer((req, res) => {
  res.writeHead(200);
  res.setHeader('Content-Type', 'text/html');
  res.setHeader('X-Foo', 'bar');
  res.end('ok');
});

server.listen(3000);

This will throw Error: Can't set headers after they are sent. when a request is made to it. If we change it to the following, it will work:

const http = require('http');

const server = http.createServer((req, res) => {
  res.statusCode = 200;
  // res.writeHead(200);
  res.setHeader('Content-Type', 'text/html');
  res.setHeader('X-Foo', 'bar');
  res.end('ok');
});

server.listen(3000);
Approval is optional

Closed by (Jul 23, 2025 12:18am UTC)

Merge details

  • The changes were not merged into master.
  • Mentions issue #953

Activity


  • Administrator mentioned in merge request !1176 (closed) 8 years ago

    mentioned in merge request !1176 (closed)

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: jakefurler

    @jcrugzz can you please review this? It's causing issues in one of my production services, and I'm having to work around it at this point in time. I think merging it would solve a lot of issues people seem to be running into.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: robertmassaioli

    Review: Approved

  • Administrator mentioned in issue #1185 (closed) 8 years ago

    mentioned in issue #1185 (closed)

  • Administrator
    Administrator @root · 7 years ago
    Author Contributor

    Created by: jcrugzz

    Thanks for the contribution @jakefurler! I cherry-picked your commit to my maintenance branch which i plan to merge later tonight.

  • Administrator closed 7 years ago

    closed

  • Administrator
    Administrator @root · 7 years ago
    Author Contributor

    Created by: jcrugzz

    superseded by #1251

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: http-party/node-http-proxy!1182
Source branch: github/fork/jakefurler/953-stop-using-write-head

Menu

Explore Projects Groups Snippets