Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • N node-http-proxy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 482
    • Issues 482
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • http ... PARTY!
  • node-http-proxy
  • Merge requests
  • !1415

Option to enable fall-through on 404 error

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/aral/404-fallthrough into master Jan 26, 2020
  • Overview 3
  • Commits 2
  • Pipelines 1
  • Changes 1

Created by: aral

Use case:

  • I’m proxying an app (Hugo)
  • If a URL does not exist there, I want to serve it from an older version of the site

I’ve modified http-proxy-middleware to enable it to fall-through to the middleware chain (see WIP PR, which depends on this one) when it encounters a 404 but without this PR, node-http-proxy already writes out the headers and so we cannot serve the fallback content.

Further context: https://github.com/chimurai/http-proxy-middleware/issues/248#

Summary of merge request

  • Add fallthrough option to the context. If present, 404 responses from the target will not be handled by node-http-proxy so that they can fall through to the middleware chain by the consumer.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/aral/404-fallthrough