Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • N node-http-proxy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 482
    • Issues 482
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • http ... PARTY!
  • node-http-proxy
  • Merge requests
  • !190

Jslint fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ajaxorg/jslint_fixes into master 13 years ago
  • Overview 8
  • Commits 6
  • Pipelines 0
  • Changes 4

Created by: fjakobs

some cleanups.

  • add missing var statements
  • remove unused variables
  • make jslint happy
  • strip white space
Checking approval status

Closed by (Jul 25, 2025 12:43am UTC)

Loading

Activity


  • Administrator
    Administrator @root · 13 years ago
    Author Contributor

    Created by: indexzero

    @fjakobs We do not use JSLint. We use JSHint with these settings: https://gist.github.com/1263182. We've been a bit lax on enforcing since we were waiting on laxcomma to his jshint:master which landed a couple weeks ago

  • Administrator
    Administrator @root started a thread on commit bb908182 13 years ago
    lib/node-http-proxy.js
    39 37 // ### Export the relevant objects exposed by `node-http-proxy`
    40 38 //
    41 39 var HttpProxy = exports.HttpProxy = require('./node-http-proxy/http-proxy').HttpProxy,
    42 ProxyTable = exports.ProxyTable = require('./node-http-proxy/proxy-table').ProxyTable,
    • Administrator
      Administrator @root · 13 years ago
      Author Contributor

      Created by: indexzero

      Why remove the ProxyTable?

  • Administrator
    Administrator @root started a thread on commit bb908182 13 years ago
    lib/node-http-proxy.js
    39 37 // ### Export the relevant objects exposed by `node-http-proxy`
    40 38 //
    41 39 var HttpProxy = exports.HttpProxy = require('./node-http-proxy/http-proxy').HttpProxy,
    42 ProxyTable = exports.ProxyTable = require('./node-http-proxy/proxy-table').ProxyTable,
    • Administrator
      Administrator @root · 13 years ago
      Author Contributor

      Created by: fjakobs

      The variable is not used. Should be

      exports.ProxyTable = ...

  • Administrator
    Administrator @root · 13 years ago
    Author Contributor

    Created by: fjakobs

    The first three commits I think are important. The other ones are more or less of a cosmetic nature.

  • Administrator
    Administrator @root · 13 years ago
    Author Contributor

    Created by: indexzero

    Thanks for the tip. I'll look into reviewing this soon.

  • Administrator
    Administrator @root · 13 years ago
    Author Contributor

    Created by: indexzero

    There have been enough changes in the codebase that this would hurt more than it helped.

  • Administrator
    Administrator @root · 13 years ago
    Author Contributor

    Created by: fjakobs

    no problem

  • Administrator
    Administrator @root · 13 years ago
    Author Contributor

    Created by: indexzero

    @fjakobs Thanks anyway. FYI. The code base it pretty much JSHint compliant now. I did some work on it over the weekend.

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: http-party/node-http-proxy!190
Source branch: github/fork/ajaxorg/jslint_fixes

Menu

Explore Projects Groups Snippets