Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • N node-http-proxy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 482
    • Issues 482
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • http ... PARTY!
  • node-http-proxy
  • Merge requests
  • !924

Fixes issues with incorrect port selection

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/pyper/fixportselection into master Dec 11, 2015
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: pyper

Hey everyone,

This is in regards to an issue I brought up in #915 yesterday. I was having an issue with incorrect port selection and assumed @BadBoy20 might be having the issue too. Anyhow, the problem for me was explicit declaration of the port was not taking precedence over the port implied by the protocol. The unit test I created was failing before I made the fix. Also, I did not check the getPort() function in common.js as it’s only purpose is setting “x-forwarded” headers in web-incoming.js and ws-incoming.js so it seemed out of scope for this issue.

Cheers.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pyper/fixportselection