Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • N node-http-proxy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 482
    • Issues 482
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • http ... PARTY!
  • node-http-proxy
  • Merge requests
  • !98

Memory leak hunting

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/isaacs/master into master 13 years ago
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: isaacs

We saw the memory usage of the http proxy servers in no.de climb way up past normal levels after fixing the crash-inducing socket termination throws. (Incidentally, that error was preventing this one from occurring.)

The attached patch makes sure to destroy the buffered request, and unhook event listeners, when there is an error. So far today, the memory usage on the proxy with this patch has been stable. The others continue to rise, occasionally hitting the point where they get forcibly HUP'ed.

Approval is optional

Closed by (Jul 22, 2025 11:41pm UTC)

Merge details

  • The changes were not merged into master.

Activity


  • Administrator
    Administrator @root · 13 years ago
    Author Contributor

    Created by: Marak

    Thanks for all the patches @isaacs!

    I had a feeling we might run into issues like this once we patched those last errors. We'll get someone to review and merge shortly.

  • Administrator
    Administrator @root · 13 years ago
    Author Contributor

    Created by: indexzero

    Cherry-picked in 0941123d

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: http-party/node-http-proxy!98
Source branch: github/fork/isaacs/master

Menu

Explore Projects Groups Snippets