Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • F ffmpeg-python
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 402
    • Issues 402
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Karl Kroening
  • ffmpeg-python
  • Merge requests
  • !12

Add support for Python3 (fixes #10)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Karl Kroening requested to merge support-python3 into master Jun 14, 2017
  • Overview 1
  • Commits 10
  • Pipelines 0
  • Changes 13

I used futurify to add Python 3 support. Aside from the auto-generated import changes, only a few things needed to be changed:

  • Add __hash__ operator to Node class
  • Encode strings as utf-8 before sending to hashlib.md5
  • Change test_repr to use proper string representation.

In addition, the following features have been added:

  • Test multiple python versions using Tox
  • Make setup.py test DTRT
  • Add setup.py classifiers
  • Cache ffmpeg download on travis

Fixes #10 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: support-python3