Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • F ffmpeg-python
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 402
    • Issues 402
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Karl Kroening
  • ffmpeg-python
  • Merge requests
  • !214

Adds a way to pass through textmode for Subprocess.Popen

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ingles98/popen_textmode into master Jun 05, 2019
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: ingles98

Subprocess.Popen textmode (argument 'text=') is needed for reading from ffmpeg's stderr to scrap for the frame count in an asynchronous way. This is wonderful for multiple jobs and when realtime feedback is needed (all the time apparently).

I felt the need for this when making a function to return progress asynchronously. However the issue is that you no longer get output from the ffmpeg process anymore heh.

I also wanted to add a ffmpeg.progress() to the package but I feel like it is too early perhaps and there are still some issues and optimizations that i want to make.

I felt like there is a high need for a simple progress feedback when i was searching around for it for myself, and since this package has been the mainframe of my work project i'd love to contribute to it.

Feel free to tell me any edits and or optimizations that I should do!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ingles98/popen_textmode