Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • F ffmpeg-python
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 402
    • Issues 402
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Karl Kroening
  • ffmpeg-python
  • Merge requests
  • !490

Support zero index stream selectors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Artem Eltyshev requested to merge github/fork/eltyy/support_zero_selectors into master Feb 09, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Hey 👋 I've just find out, that the library is not working as I expected in the case, when I tried to select stream with index 0. Examples:

ffmpeg.input('input.mp4').filter('scale', 360, -1).output('out.mp4').get_args()
# ['-i', 'input.mp4', '-filter_complex', '[0]scale=360:-1[s0]', '-map', '[s0]', 'out.mp4']

ffmpeg.input('input.mp4').node.stream(selector=1).filter('scale', 360, -1).output('out.mp4').get_args()
['-i', 'input.mp4', '-filter_complex', '[0:1]scale=360:-1[s0]', '-map', '[s0]', 'out.mp4']

Everything is ok, but:

ffmpeg.input('input.mp4').node.stream(selector=0).filter('scale', 360, -1).output('out.mp4').get_args()
# ['-i', 'input.mp4', '-filter_complex', '[0]scale=360:-1[s0]', '-map', '[s0]', 'out.mp4']

Instead of selecting specific stream, the whole input was selected. I think it should be:

ffmpeg.input('input.mp4').node.stream(selector=0).filter('scale', 360, -1).output('out.mp4').get_args()
# ['-i', 'input.mp4', '-filter_complex', '[0:0]scale=360:-1[s0]', '-map', '[s0]', 'out.mp4']
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/eltyy/support_zero_selectors