Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A AndroidAsync
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 333
    • Issues 333
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Koushik Dutta
  • AndroidAsync
  • Merge requests
  • !126

Optimize framing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/paulpdaniels/optimize-framing into master Mar 26, 2014
  • Overview 1
  • Commits 4
  • Pipelines 0
  • Changes 3

Created by: paulpdaniels

Added some simple math optimizations to the HybiParser by removing extraneous calls to Math.pow and Math.floor. By taking advantage of int/long division can also remove some of the explicit casts. This mostly applies to the case where the message is over 65535 bytes.

Added an overload for WebSocket.send and HybiParser.frame methods which allows for sending buffer slices of an array without having to explicitly copy data into a fitted array. As a result also had to rearrange the private frame overloads so as to avoid the namespace collision.

I believe it should be a non-breaking change, unless users have provided their own WebSocket implementations...

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/paulpdaniels/optimize-framing