Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A AndroidAsync
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 333
    • Issues 333
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Koushik Dutta
  • AndroidAsync
  • Merge requests
  • !278

If the emitter is closed while processing data, then just eat the remaining data.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Gregorios Leach requested to merge github/fork/simtel12/safe_handle_closed into 1.x Nov 14, 2014
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Don't throw an exception, as this is a valid case. This can happen if a request is cancelled while it's still processing the data.

Code is from 11/11/2014. The pair of callstacks that lead me to this:

E/VIMEO ( 5941): Error getting video: E/VIMEO ( 5941): java.util.concurrent.CancellationException E/VIMEO ( 5941): at com.koushikdutta.async.future.SimpleFuture.cancelInternal(SimpleFuture.java:39) E/VIMEO ( 5941): at com.koushikdutta.async.future.SimpleFuture.cancel(SimpleFuture.java:54) E/VIMEO ( 5941): at com.koushikdutta.ion.Ion.cancelAll(Ion.java:351) E/VIMEO ( 5941): at com.koushikdutta.ion.Ion.cancelAll(Ion.java:382) E/VIMEO ( 5941): at tv.ouya.console.launcher.store.DetailsActivity.onPause(DetailsActivity.java:568) E/VIMEO ( 5941): at android.app.Activity.performPause(Activity.java:5161) E/VIMEO ( 5941): at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1225) E/VIMEO ( 5941): at android.app.ActivityThread.performPauseActivity(ActivityThread.java:2825) E/VIMEO ( 5941): at android.app.ActivityThread.performPauseActivity(ActivityThread.java:2794) E/VIMEO ( 5941): at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:2772) E/VIMEO ( 5941): at android.app.ActivityThread.access$800(ActivityThread.java:130) E/VIMEO ( 5941): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1212) E/VIMEO ( 5941): at android.os.Handler.dispatchMessage(Handler.java:99) E/VIMEO ( 5941): at android.os.Looper.loop(Looper.java:137) E/VIMEO ( 5941): at android.app.ActivityThread.main(ActivityThread.java:4745) E/VIMEO ( 5941): at java.lang.reflect.Method.invokeNative(Native Method) E/VIMEO ( 5941): at java.lang.reflect.Method.invoke(Method.java:511) E/VIMEO ( 5941): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786) E/VIMEO ( 5941): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553) E/VIMEO ( 5941): at dalvik.system.NativeStart.main(Native Method)

-- and --

E/AndroidRuntime( 5941): FATAL EXCEPTION: ion-ion E/AndroidRuntime( 5941): java.lang.RuntimeException: Not all data was consumed by Util.emitAllData E/AndroidRuntime( 5941): at com.koushikdutta.async.Util.emitAllData(Util.java:45) E/AndroidRuntime( 5941): at com.koushikdutta.async.http.ResponseCacheMiddleware$CachedBodyEmitter.spewInternal(ResponseCacheMiddleware.java:413) E/AndroidRuntime( 5941): at com.koushikdutta.async.http.ResponseCacheMiddleware$1.run(ResponseCacheMiddleware.java:167) E/AndroidRuntime( 5941): at com.koushikdutta.async.AsyncServer.lockAndRunQueue(AsyncServer.java:708) E/AndroidRuntime( 5941): at com.koushikdutta.async.AsyncServer.runLoop(AsyncServer.java:725) E/AndroidRuntime( 5941): at com.koushikdutta.async.AsyncServer.run(AsyncServer.java:626) E/AndroidRuntime( 5941): at com.koushikdutta.async.AsyncServer.access$700(AsyncServer.java:41) E/AndroidRuntime( 5941): at com.koushikdutta.async.AsyncServer$13.run(AsyncServer.java:568)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/simtel12/safe_handle_closed