Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A AndroidAsync
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 333
    • Issues 333
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Koushik Dutta
  • AndroidAsync
  • Merge requests
  • !331

fix issue 461

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/mkoslacz/issue_461 into master Mar 16, 2015
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: mkoslacz

I have managed to apply workaround to issue #461 mentioned here: https://github.com/koush/ion/issues/461 based on this commit https://github.com/candrews/HttpResponseCache/commit/a93c92d1d8b87778ac7bb2fa2fe2759e7ca06219 I use local copy of MessageDigest in com.koushikdutta.async.util.FileCache instead of getting instance of MessageDigest each time. It prevents from occuring java.util.ConcurrentModificationException at com.koushikdutta.async.util.FileCache.toKeyString().

All tests pass except com.koushikdutta.async.test.ConscryptTests#testConscryptSSLEngineNPNHandshakeBug - thrown exception:

java.lang.reflect.InvocationTargetException at com.koushikdutta.async.test.ConscryptTests.testConscryptSSLEngineNPNHandshakeBug(ConscryptTests.java:111) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853) Caused by: java.lang.SecurityException at com.google.android.gms.common.security.ProviderInstallerImpl.insertProvider(SourceFile:59) ... 15 more

It doesn't looks like it's caused by changes introduced by me (but, of course, I may be wrong).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mkoslacz/issue_461