Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A AndroidAsync
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 333
    • Issues 333
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Koushik Dutta
  • AndroidAsync
  • Merge requests
  • !696

handle url decode exceptions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open skykit-adamvernier requested to merge github/fork/skykit-adamvernier/decodefix into master Apr 08, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

If a url is requested that contains a % character the server will crash. This change will handle exceptions from UrlDecoder.

java.lang.IllegalArgumentException: URLDecoder: Incomplete trailing escape (%) pattern at java.net.URLDecoder.decode(URLDecoder.java:196) at java.net.URLDecoder.decode(URLDecoder.java:101) at com.koushikdutta.async.http.server.AsyncHttpServer$1$1.onBody(AsyncHttpServer.java:111) at com.koushikdutta.async.http.server.AsyncHttpServerRequestImpl$2.onStringAvailable(AsyncHttpServerRequestImpl.java:83) at com.koushikdutta.async.LineEmitter.onDataAvailable(LineEmitter.java:42) at com.koushikdutta.async.Util.emitAllData(Util.java:23) at com.koushikdutta.async.AsyncSSLSocketWrapper.onDataAvailable(AsyncSSLSocketWrapper.java:335) at com.koushikdutta.async.AsyncSSLSocketWrapper$6.onDataAvailable(AsyncSSLSocketWrapper.java:322) at com.koushikdutta.async.Util.emitAllData(Util.java:23) at com.koushikdutta.async.AsyncNetworkSocket.onReadable(AsyncNetworkSocket.java:160) at com.koushikdutta.async.AsyncServer.runLoop(AsyncServer.java:878) at com.koushikdutta.async.AsyncServer.run(AsyncServer.java:726) at com.koushikdutta.async.AsyncServer.access$800(AsyncServer.java:46) at com.koushikdutta.async.AsyncServer$8.run(AsyncServer.java:680)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/skykit-adamvernier/decodefix