Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A AndroidAsync
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 333
    • Issues 333
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Koushik Dutta
  • AndroidAsync
  • Merge requests
  • !80

Added emitEvent methods

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/IlyaGulya/feature into master 11 years ago
  • Overview 10
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: IlyaGulya

Added emitEvent methods, used to emit events without arguments.

Approval is optional

Merged by Koushik DuttaKoushik Dutta 11 years ago (Nov 28, 2013 8:31pm UTC) 11 years ago

Merge details

  • Changes merged into master with e3d40873.
  • Deleted the source branch.

Activity


  • Koushik Dutta
    Koushik Dutta @koush · 11 years ago
    Owner

    How is this different from emit?

  • Administrator
    Administrator @root · 11 years ago
    Author Contributor

    Created by: IlyaGulya

    emit(String, Acknowledge) and emit(String) sends strings, not events. (Message type 3 instead of 5)

  • Koushik Dutta
    Koushik Dutta @koush · 11 years ago
    Owner

    Couple things then, call the method emit. No need to qualify it with a type, since the signatures do not match.

    Also, fix the formatting to match mine. Spaces, not tabs. Thanks!

  • Koushik Dutta
    Koushik Dutta @koush · 11 years ago
    Owner

    Also, is there a need for the try/catch? What throws here?

  • Administrator
    Administrator @root · 11 years ago
    Author Contributor

    Created by: IlyaGulya

    But if i call method emit it will conflict with emit methods for strings. Yep, try/catch is needed. Here throws JSONException.

  • Administrator
    Administrator @root · 11 years ago
    Author Contributor

    Created by: IlyaGulya

    Any comments? :)

  • Koushik Dutta
    Koushik Dutta @koush · 11 years ago
    Owner

    Sorry, missed this.

    That's fine, I prefer it to be a method overload and called emit. They take different arguments, no? It should work fine.

  • Administrator
    Administrator @root · 11 years ago
    Author Contributor

    Created by: IlyaGulya

    Of course method overload would be better, but there is already methods with the same arguments

  • Koushik Dutta
    Koushik Dutta @koush · 11 years ago
    Owner

    Oh, I see now.

  • Administrator
    Administrator @root · 11 years ago
    Author Contributor

    Merged by: koush at 2013-11-28 20:31:11 UTC

  • Koushik Dutta closed 11 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Administrator
Koushik Dutta
Reference: koush/AndroidAsync!80
Source branch: github/fork/IlyaGulya/feature

Menu

Explore Projects Groups Snippets