Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M MathJax
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 304
    • Issues 304
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MathJax
  • MathJax
  • Merge requests
  • !1556

Improve menu placement. #1434

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Davide P. Cervone requested to merge github/fork/dpvc/issue1434 into develop Jul 12, 2016
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 1

Use getBoundingClientRect() to improve handling of menu placement when the body is scrolled or has margin settings. Resolves issue #1434 (closed).

Here bbox.right gives the position of the right-hand side of the body, unless it is scrolled left, in which case the bbox.left will be negative, so we add it in. These don't seem to take the left margin into account, so we add that in as well.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dpvc/issue1434