Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M MathJax
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 304
    • Issues 304
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MathJax
  • MathJax
  • Merge requests
  • !1791
An error occurred while fetching the assigned milestone of the selected merge_request.

Fix CD problems cause by getNode(). #1691

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Davide P. Cervone requested to merge github/fork/dpvc/issue1691 into develop 8 years ago
  • Overview 5
  • Commits 2
  • Pipelines 0
  • Changes 1

Some situations caused CD to produce Math Processing Errors (see #1691 (closed) for reduced test case). This was caused by the getNode() method, which did not descend into all the children. This PR fixes the problem by using a breadth-first search in getNode(), but stopping at nodes with ids, as these are other rendered MathML nodes (we only want to find nodes that are "direct" children of the current element, not similarly named ones inside nested elements).

Resolves #1691 (closed).

Compare
  • develop (base)

and
  • latest version
    161a3899
    2 commits, 2 years ago

0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/dpvc/issue1691

Menu

Explore Projects Groups Snippets