Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P PHP_XLSXWriter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 101
    • Issues 101
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 24
    • Merge requests 24
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mk-j
  • PHP_XLSXWriter
  • Merge requests
  • !210

Ignore quoted format strings when determining number format

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/lieszkol/patch-2 into master Jul 24, 2018
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: lieszkol

When determining the number format, do not consider characters that have been escaped. For example, a number format like this: #,##0" W/m2" Should not be interpreted as an "n_date" column just because it contains the character "m". This implements a simple solution, where if the format string contains an double-quote after the search string, it does not match. Check the regex for the "M" (month) regex here. A more robust regex is described here A better solution would be to not use regex here at all but something more along the lines of how numberFormatStandardized() reads through the string.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/lieszkol/patch-2