Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P PHP_XLSXWriter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 101
    • Issues 101
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 24
    • Merge requests 24
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mk-j
  • PHP_XLSXWriter
  • Merge requests
  • !72

Fixed issue: Ctrl character in value strings break the final document

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/c-schmitz/ctrl_chars into 2016-rollup Sep 21, 2016
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: c-schmitz

This little patch prevents the problem that any (UTF-8 or not) control character may break the XLSX file. Excel usually complains about the file being broken and is not able to repair it. While you can argue that this should not be in the value text in general I think that control characters serve no purpose at all in an Excel sheet.

The patch strips all control characters that are not CR, LF or TAB before writing the value to the XML file.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/c-schmitz/ctrl_chars