Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D design
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Primer
  • design
  • Merge requests
  • !193

Button component interface guidelines

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Pavithra Kodmad requested to merge pk/button-component into main Nov 10, 2021
  • Overview 43
  • Commits 3
  • Pipelines 0
  • Changes 2

Took a quick stab at distilling my research at https://github.com/github/primer/issues/382 to a button component guideline here. Thanks @ashygee for all the figma files!

Seeking feedback and help for the following stuff

  • Is this a good addition? What do you think of the tone and information in the post? I tried to go off of other documents in the components section.
  • A separate component for ButtonLink. Thoughts?
  • Removal of Outline button and large size buttons. What about the icon sizes though?
  • How do I get it to display in the Components navigation section?

Also seeking design help on figmas for

  • Anatomy structure with current API terms
  • Anatomy structure of icon only button
  • Button Link examples
  • Full range of states for Invisible Button

Screen Shot 2021-11-10 at 6 56 45 pm

cc - @langermank @simurai @ashygee

Preview link https://design-mlgkrxoax-primer.vercel.app/design/components/button

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: pk/button-component