Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D design
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Primer
  • design
  • Merge requests
  • !387

started work on icons section

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lukas Oppermann requested to merge migrate-octicons into main Feb 06, 2023
  • Overview 8
  • Commits 15
  • Pipelines 0
  • Changes 15

Once completed this fixes https://github.com/github/primer/issues/1630.

Related

  • move package docs to repos: https://github.com/primer/octicons/pull/916
  • https://github.com/primer/design/issues/389

Redirects

The following redirects are needed once this PR gets merged

  • https://primer.style/octicons/ → https://primer.style/foundations/icons/
  • https://primer.style/octicons/guidelines/design → https://primer.style/foundations/icons/design-guidelines
  • https://primer.style/octicons/:icon-name → https://primer.style/foundations/icons/:icon-name

Todo

  • build:icons needs to be run on build of docs the json from @primer/octicons-react can be used
  • ping @rezrah once this PR has been merged to add the redirects
  • Archive docs from octicons

Problems

  • blob-stream throws errors in the individual icon pages (will try to replace with native stream)
  • jsPDF creates an error when gatsby is built
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: migrate-octicons