Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Issues
  • #447
Closed
Open
Issue created Jul 20, 2018 by Administrator@rootContributor

Python 3.7 compatibility - async is a reserved word

Created by: jasontibbitts

I was working on updating the Fedora package (finally) and switching it over to python3 and ran into an issue: async is a reserved word in python 3.7. This means that the async function in ui/init.py causes various syntax errors:

  File "/usr/lib/python3.7/site-packages/solaar/ui/__init__.py", line 78
    def async(function, *args, **kwargs):
            ^
SyntaxError: invalid syntax

  File "/usr/lib/python3.7/site-packages/solaar/ui/config_panel.py", line 26
    from solaar.ui import async as _ui_async
                              ^
SyntaxError: invalid syntax

  File "/usr/lib/python3.7/site-packages/solaar/ui/window.py", line 34
    from solaar.ui import async as _ui_async
                              ^
SyntaxError: invalid syntax

It should be pretty easy to rename this "ui_async" or something like that, and then change the three imports. Conveniently they all import async as _ui_async so it's not even necessary to fix up anything else.

Assignee
Assign to
Time tracking