Last commit broke solaar's GUI - no configuration options shown for any device

Created by: arigit

There were a a series of commit done on Aug 11 - the last one of which completely broke the GUI, this one:

https://github.com/pwr/Solaar/commit/867edf8516f6a5a2ec78a99cf2755bd7bcc4e99d "Merge pull request #146 from tristianc/master - Added border around tree view."

This is on Ubuntu 18.04 LTS.

The application runs and the tray icon shows, clicking on it the list of logitech devices shows as usual, and after selecting one, the regular properties window opens, but instead of containing device properties (DPI, battery level etc) it is completely empty except for a label saying "Select a device" (?)

Running solaar from the command the command line shows a string of error messages that pop up every time the "empty properties window" opens:

(solaar:3570): Gtk-CRITICAL **: 14:45:35.469: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed Traceback (most recent call last): File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/init.py", line 165, in _status_changed window.update(device, need_popup) File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 768, in update selected_device_id = _find_selected_device_id() File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 370, in _find_selected_device_id model, item = selection.get_selected() AttributeError: 'NoneType' object has no attribute 'get_selected' Traceback (most recent call last): File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/init.py", line 165, in _status_changed window.update(device, need_popup) File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 768, in update selected_device_id = _find_selected_device_id() File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 370, in _find_selected_device_id model, item = selection.get_selected() AttributeError: 'NoneType' object has no attribute 'get_selected' Traceback (most recent call last): File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/init.py", line 165, in _status_changed window.update(device, need_popup) File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 768, in update selected_device_id = _find_selected_device_id() File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 370, in _find_selected_device_id model, item = selection.get_selected() AttributeError: 'NoneType' object has no attribute 'get_selected' Traceback (most recent call last): File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/init.py", line 165, in _status_changed window.update(device, need_popup) File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 768, in update selected_device_id = _find_selected_device_id() File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 370, in _find_selected_device_id model, item = selection.get_selected() AttributeError: 'NoneType' object has no attribute 'get_selected' Traceback (most recent call last): File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/init.py", line 165, in _status_changed window.update(device, need_popup) File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 768, in update selected_device_id = _find_selected_device_id() File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 370, in _find_selected_device_id model, item = selection.get_selected() AttributeError: 'NoneType' object has no attribute 'get_selected' Traceback (most recent call last): File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/init.py", line 165, in _status_changed window.update(device, need_popup) File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 768, in update selected_device_id = _find_selected_device_id() File "..../solaar/test/Solaar-867edf85/lib/solaar/ui/window.py", line 370, in _find_selected_device_id model, item = selection.get_selected() AttributeError: 'NoneType' object has no attribute 'get_selected'

For people affected by this, you can still get all the latest changes (including the one related to sleep/wake-up) by using the prior to last tree

https://github.com/pwr/Solaar/tree/dcd1a882505518441b737147ff463a6101e517aa

which contains all commits up until: https://github.com/pwr/Solaar/commit/dcd1a882505518441b737147ff463a6101e517aa