Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Issues
  • #798
Closed
Open
Issue created Jun 04, 2020 by Administrator@rootContributor

Incorrect packaging of the `/etc` directory

Created by: FFY00

Information

  • Solaar version (git describe --tags if cloned from Solaar repository): master

Describe the bug A Solaar wheel contains the following.

.install-cache/pkg/
├── etc
│   ├── udev
│   │   └── rules.d
│   │       └── 42-logitech-unify-permissions.rules
│   └── xdg
│       └── autostart
│           └── solaar.desktop
├── hidapi
│   ├── hidconsole.py
│   ├── __init__.py
│   └── udev.py
├── logitech_receiver
│   ├── base.py
│   ├── base_usb.py
│   ├── common.py
│   ├── descriptors.py
│   ├── hidpp10.py
│   ├── hidpp20.py
│   ├── i18n.py
│   ├── __init__.py
│   ├── listener.py
│   ├── notifications.py
│   ├── receiver.py
│   ├── settings.py
│   ├── settings_templates.py
│   ├── special_keys.py
│   └── status.py
├── solaar
│   ├── cli
│   │   ├── config.py
│   │   ├── __init__.py
│   │   ├── pair.py
│   │   ├── probe.py
│   │   ├── show.py
│   │   └── unpair.py
│   ├── configuration.py
│   ├── gtk.py
│   ├── i18n.py
│   ├── __init__.py
│   ├── listener.py
│   ├── tasks.py
│   ├── ui
│   │   ├── about.py
│   │   ├── action.py
│   │   ├── config_panel.py
│   │   ├── icons.py
│   │   ├── __init__.py
│   │   ├── notify.py
│   │   ├── pair_window.py
│   │   ├── tray.py
│   │   └── window.py
│   └── upower.py
├── solaar-1.0.2.data
│   ├── data
│   │   └── share
│   │       ├── applications
│   │       │   └── solaar.desktop
│   │       ├── icons
│   │       │   └── hicolor
│   │       │       └── scalable
│   │       │           └── apps
│   │       │               └── solaar.svg
│   │       └── solaar
│   │           └── icons
│   │               ├── light_000.png
│   │               ├── light_020.png
│   │               ├── light_040.png
│   │               ├── light_060.png
│   │               ├── light_080.png
│   │               ├── light_100.png
│   │               ├── light_unknown.png
│   │               ├── solaar-attention.svg
│   │               ├── solaar-init.svg
│   │               └── solaar.svg
│   └── scripts
│       ├── solaar
│       └── solaar-cli
└── solaar-1.0.2.dist-info
    ├── COPYING
    ├── METADATA
    ├── RECORD
    ├── top_level.txt
    └── WHEEL

22 directories, 61 files

/etc is wrongfully present at the top level, it shouldn't be there. Using a correct (follows the spec) installer, it would result in the file being installed to the python modules directory. Unfortunately, PEP427 does not specify any way of installing to sysconfdir, we should put it under data and copy it at runtime if not present.

Another thing, I don't think we should be shipping hidapi and logitech_receiver as top-level modules.

To Reproduce Steps to reproduce the behavior: python setup.py bdist_wheel

Assignee
Assign to
Time tracking