Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Merge requests
  • !144

Russian translation added.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/DJm00n/master into master Dec 17, 2013
  • Overview 27
  • Commits 3
  • Pipelines 0
  • Changes 10

Created by: DJm00n

I think there is some work needed in Solar for better localization. You need to use gettext.ngettext function for plural forms and do NOT concatenate strings like this:

_UNIFYING_RECEIVER_TEXT = (
                gettext.ngettext("No device paired") + '.\n\n' + _("Up to %d devices can be paired to this receiver") + '.',
                '%d ' + _("paired devices") + '\n\n' + _("Up to %d devices can be paired to this receiver") + '.',

Instead write something like this:

_UNIFYING_RECEIVER_TEXT = (
                _("No device paired.\n\n"Up to %d devices can be paired to this receiver.",
                _("%d paired devices.\n\nUp to %d devices can be paired to this receiver.",

See http://techbase.kde.org/Development/Tutorials/Localization/i18n_Mistakes for details.


I'll try to do some work on this if I will have free time.


Update: Added some example localization fixes. Trying not to break anything. :)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/DJm00n/master