Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Merge requests
  • !290

fixed online bit readout which has to be inverted according to this: …

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/verybadsoldier/invert-online-bit into master Sep 16, 2016
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: verybadsoldier

I was suffering from a bug described here: https://github.com/pwr/Solaar/issues/289

I might be totally wrong but I think the reason is quite simple: The bit in the notification message that indicates if the device is online or not is interpreted inversely. According to this document (which is actualyl written by you?): https://lekensteyn.nl/files/logitech/logitech_hidpp10_specification_for_Unifying_Receivers.pdf

Means '0' -> device is online and '1' -> device is offline. I think that was wrong in the code so I inverted it. My problem is gone now.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/verybadsoldier/invert-online-bit